Add #available checks for NSKeyedArchiver methods in tests #21301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test macOS |
|
@swift-ci Please smoke test Linux |
jrose-apple
approved these changes
Dec 13, 2018
| @@ -70,6 +70,8 @@ ErrorBridgingTests.test("NSCopying") { | |||
| } | |||
| } | |||
|
|
|||
| // Gated on the availability of NSKeyedArchiver.archivedData(withRootObject:). | |||
| @available(macOS 10.11, iOS 9.0, tvOS 9.0, watchOS 2.0, *) | |||
There was a problem hiding this comment.
Since those are the earliest public versions of tvOS and watchOS, it'd also be correct to leave them off, but it's up to you.
There was a problem hiding this comment.
We tend to explicitly place those on our APIs where relevant so I stuck them here for consistency; good to know, though! I'll leave them for now so I don't have to retrigger testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolves 46702315