[5.0] [Runtime] Properly unique foreign witness tables. #21303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
changed the title
|
@swift-ci please test |
|
Oops! |
AnnaZaks
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Namefield of a type descriptor is not the appropriateway to compare types for uniquing. Instead, use
TypeContextIdentity.Otherwise, we end up coalescing witness tables for two imported types
that have the same base name but are in different parent contexts, e.g.,
NSData.WritingOptionsandJSONSerialization.WritingOptions.Fixes rdar://problem/46685973.