[CMake] Require SWIFT_COMPONENT for add_swift_host_tool #21326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable, any objections @gottesmm? |
|
@swift-ci please test |
|
@xiaobai +1 from me! The general design here is that all of the install in component calls should be hidden in the helper functions. I just have never had time to finish. So I am all for anything that helps us go towards that world. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all but one instance of
add_swift_host_toolwere specifying aSWIFT_COMPONENT. The one that did not (swift-stdlib-tool) was callingswift_install_in_componentmanually. This means that we never were adding swift-stdlib-tool toSWIFT_EXPORTSorSWIFT_BUILDTREE_EXPORTS.In this PR I make swift-stdlib-tool specify
SWIFT_COMPONENTin itsadd_swift_host_toolinvocation and remove the manual call toswift_install_in_component.Additionally, I change
add_swift_host_toolto require aSWIFT_COMPONENTso that tool installations are always associated with at least one swift component.