StdlibUnittest: port the test harness to Windows #21356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troughton
reviewed
Dec 15, 2018
compnerd
force-pushed
the
harness
branch
2 times, most recently
from
43cccd8 to
7d5672f
Compare
|
@swift-ci please test |
compnerd
changed the title
|
Build failed |
|
Build failed |
Windows uses DOS line endings which appear through the PIPE endpoints. We currently split on line feeds only, leaving the carriage return in place. Without this, the messages on the communication pipe would not be interpreted correctly.
Adjust the abort behaviour on Windows. The aborts would cause a large number of dialogs to appear. This reduces the load a bit and is crucial for getting tests to run without manual intervention.
Add a vectored exception handler for illegal instructions on Windows. This allows us to emulate `signal(SIGTRAP, ...)`. This allows better coverage of tests.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
CC: @moiseev |
|
CC: @lorentey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.