Skip to content

Add a test for a compiler crasher with -O -whole-module-optimization -sanitize=address #21385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kubamracek
Copy link
Contributor

Add a test for apple/swift-llvm#133.

@@ -0,0 +1,19 @@
// RUN: %target-build-swift -O -whole-module-optimization -sanitize=address %s -o %t
// RUN: %target-codesign %t
// RUN: %target-run %t
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is %target-run-simple-swift(-O -whole-module-optimization -sanitize=address).

@CodaFi
Copy link
Contributor

CodaFi commented Nov 18, 2019

Still good to have this test

@swift-ci please smoke test

@yln yln requested a review from danliew-apple February 10, 2020 17:40
// RUN: %target-run %t

// REQUIRES: executable_test
// REQUIRES: objc_interop
Copy link
Contributor

@yln yln Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REQUIRES: foundation (instead of objc_interop)

@danliew-apple
Copy link
Contributor

Interesting this looks like an old PR that didn't get merged.

Copy link
Contributor

@danliew-apple danliew-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this test is in test/Interpreter/, we aren't using the interpreter in this test are we?
It sound probably be in test/Sanitizers with the other sanitizer test cases.

// RUN: %target-run %t

// REQUIRES: executable_test
// REQUIRES: objc_interop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs REQUIRES: asan_runtime if we are actually going to run.

@CodaFi
Copy link
Contributor

CodaFi commented Apr 14, 2020

Merged in #31008.

@CodaFi CodaFi closed this Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants