Skip to content

SILGen: Fix partial application of enum case with one-element labeled tuple #21394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2018
Merged

SILGen: Fix partial application of enum case with one-element labeled tuple #21394

merged 1 commit into from
Dec 20, 2018

Conversation

slavapestov
Copy link
Contributor

Fixes rdar://problem/46748491.

@slavapestov slavapestov requested a review from jckarter December 18, 2018 01:13
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov slavapestov mentioned this pull request Dec 18, 2018
Merged
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@slavapestov
Copy link
Contributor Author

These are from Result and the XFAILs will be removed shortly:

20:44:20 UPasses:
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, Alamofire, 4.0, a5cd9e, iOS Example, generic/platform=iOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, Kickstarter-ReactiveExtensions, 4.0, 6b7887, ReactiveExtensions-TestHelpers-iOS, generic/platform=iOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, Kickstarter-ReactiveExtensions, 4.0, 6b7887, ReactiveExtensions-iOS, generic/platform=iOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, ReactiveCocoa, 4.0, 72dd20, ReactiveCocoa-watchOS, generic/platform=watchOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, ReactiveCocoa, 4.0, 72dd20, ReactiveCocoa-tvOS, generic/platform=tvOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, ReactiveCocoa, 4.0, 72dd20, ReactiveCocoa-iOS, generic/platform=iOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, ReactiveCocoa, 4.0, 72dd20, ReactiveCocoa-macOS, generic/platform=macOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, ReactiveSwift, 4.0, 46fb4d, ReactiveSwift-watchOS, generic/platform=watchOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, ReactiveSwift, 4.0, 46fb4d, ReactiveSwift-tvOS, generic/platform=tvOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, ReactiveSwift, 4.0, 46fb4d, ReactiveSwift-iOS, generic/platform=iOS
20:44:20   UPASS: https://bugs.swift.org/browse/SR-9497, ReactiveSwift, 4.0, 46fb4d, ReactiveSwift-macOS, generic/platform=macOS

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test Linux

jckarter
jckarter approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Slava!

@slavapestov slavapestov force-pushed the enum-curry-thunk-regression branch from 340597b to 396007d Compare December 19, 2018 20:21
@slavapestov
Copy link
Contributor Author 

15:19:35 TIMEOUT: test_dwarf (lang/swift/step_into_override/TestStepIntoOverride.py)

@dcci Is there a bug for these timeouts? They seem to be happening occasionally.

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@dcci
Copy link
Member

dcci commented Dec 19, 2018

@slavapestov no, can you file a rdar please?

@dcci
Copy link
Member

dcci commented Dec 19, 2018

I tried and wasn't able to reproduce locally, FWIW.

@slavapestov slavapestov merged commit b697b2c into swiftlang:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slavapestov @dcci @jckarter