Skip to content

[Sema] Don't print __consuming when suggesting protocol requirement stubs #21410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2018
Merged

[Sema] Don't print __consuming when suggesting protocol requirement stubs #21410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/Sema/TypeCheckProtocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2624,6 +2624,12 @@ printRequirementStub(ValueDecl *Requirement, DeclContext *Adopter,
Options.SkipAttributes = true;
Options.FunctionDefinitions = true;
Options.PrintAccessorBodiesInProtocols = true;

// FIXME: Once we support move-only types, remove this if the
// conforming type is move-only. Until then, don't suggest printing
// __consuming on a protocol requirement.
Options.ExcludeAttrList.push_back(DAK_Consuming);

Options.FunctionBody = [&](const ValueDecl *VD, ASTPrinter &Printer) {
Printer << " {";
Printer.printNewline();
Expand Down
8 changes: 8 additions & 0 deletions test/decl/protocol/conforms/fixit_stub.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,3 +198,11 @@ protocol ProtocolHasSubscriptFunction {
class ProtocolHasSubscriptFunctionAdopter: ProtocolHasSubscriptFunction { // expected-error{{type 'ProtocolHasSubscriptFunctionAdopter' does not conform to protocol 'ProtocolHasSubscriptFunction'}}

}

protocol ProtocolHasConsumingRequirement {
__consuming func foo() // expected-note {{protocol requires function 'foo()' with type '() -> ()'; do you want to add a stub?}} {{81-81=\n func foo() {\n <#code#>\n \}\n}}
}

struct ProtocolHasConsumingRequirementAdopter: ProtocolHasConsumingRequirement { // expected-error {{type 'ProtocolHasConsumingRequirementAdopter' does not conform to protocol 'ProtocolHasConsumingRequirement'}}

}