[5.0] Ban variadic enum cases #21420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be supported in the long term, but in the short term, crashing is not accepable behavior. rdar://46821582
|
@swift-ci Please test |
jrose-apple
approved these changes
Dec 19, 2018
|
@swift-ci please test source compatibility |
|
Looks like the failures are all unrelated to this change. |
|
@CodaFi's work on enum default arguments involves switching payload emission over to use an ArgumentSource IIRC; so it might be possible to handle varargs there as well. |
AnnaZaks
approved these changes
Dec 19, 2018
|
Yeah, I saw that. And yes, done properly that's the right way to get this to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be supported in the long term, but in the short term, crashing is not accepable behavior.
rdar://46821582
5.0 version of #21419. TODO: CCC