[ModuleInterface] <rdar://46073729> Re-enable test that appears to be working now. #21425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working now, unclear why initially failing.
|
@swift-ci please test |
jrose-apple
approved these changes
Dec 19, 2018
|
@swift-ci Please asan test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent several days now trying to produce anything like the failure we saw earlier in CI and I cannot. I read through all the code paths related to generating the diagnostic in question and they all look like they send the right source manager to the formatting operation, and asan shows nothing going wrong.
I'm annoyed at the absence of an explanation but absent one I don't see a reason to leave this disabled, so I'm proposing re-enabling it (there was also a change to a line number in the meantime, due to import printing changes).
rdar://46073729