[test] Change stored-properties-client to an executable test #21426
Conversation
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Linux... 🤦♂️ |
|
I mean, Windows too. @compnerd just added a substitution for library names because of this. |
| // RUN: %target-swift-frontend -typecheck %S/stored-properties.swift -module-name StoredProperties -emit-parseable-module-interface-path %t/StoredProperties.swiftinterface | ||
| // RUN: %target-swift-frontend -emit-ir %s -I %t -enable-parseable-module-interface | %FileCheck %s -check-prefix CHECK -check-prefix COMMON | ||
| // RUN: %target-build-swift -emit-library %S/stored-properties.swift -module-name StoredProperties -o %t/libStoredProperties.dylib |
There was a problem hiding this comment.
Please use %target-library-name(StoredProperties)
|
|
||
| // REQUIRES: rdar_46486517 | ||
| // RUN: %target-swift-frontend -typecheck %S/stored-properties.swift -enable-resilience -module-name StoredProperties -emit-parseable-module-interface-path %t/StoredProperties.swiftinterface | ||
| // RUN: %target-build-swift -emit-library %S/stored-properties.swift -module-name StoredProperties -o %t/libStoredProperties.dylib |
harlanhaskins
force-pushed
the
dropping-this-client
branch
from
c13f233 to
cd844bb
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
harlanhaskins
force-pushed
the
dropping-this-client
branch
from
cd844bb to
aeeab87
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
harlanhaskins
force-pushed
the
dropping-this-client
branch
from
aeeab87 to
e2e6876
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
harlanhaskins
force-pushed
the
dropping-this-client
branch
from
e2e6876 to
1c8a395
Compare
|
@swift-ci please test |
|
Build failed |
harlanhaskins
force-pushed
the
dropping-this-client
branch
from
1c8a395 to
881e1b0
Compare
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test |
This test was overfitting what it was trying to test, causing different targets (and even different assert configurations) to fail to match. Instead, make this an executable test and ensure that round-tripping through setting and getting behaves as expected. Fixes rdar://46486517
harlanhaskins
force-pushed
the
dropping-this-client
branch
from
881e1b0 to
3efc8b9
Compare
|
@swift-ci please smoke test Linux |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Test was enabled in swiftlang#21426, but it was not marked as executable, and the Android CI has been trying to run it in the builder, and failing.
This test was overfitting what it was trying to test, causing different
targets (and even different assert configurations) to fail to match.
Instead, make this an executable test and ensure that round-tripping
through setting and getting behaves as expected.
Fixes rdar://46486517