[swift-evolve] More source order dependencies in tests #21427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several tests implicitly depended on the order of declarations in RawRepresentable. This change loosens their requirements.
These tests may not *reliably* fail with shuffled standard libraries, so we can’t use XFAIL, which fails if the test succeeds.
A lot of these are source-order-dependent and there’s no particular reason to think they’re relevant to resilience testing.
One of the two issues preventing us from running test/api-digester/stability-stdlib-abi.swift in swift-evolve tests has been fixed; delete the comment referencing it. There’s another bug that still needs to be fixed, so we still aren’t running this yet.
|
@swift-ci please smoke test |
jrose-apple
reviewed
Dec 19, 2018
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grab bag of test changes for swift-evolve:
RawRepresentablecould fail if that protocol's members were shuffled. Switch those to use CHECK-DAG instead of CHECK-NEXT.Tagging @jrose-apple to make sure the ParsableInterface tests aren't made useless by this change.