[ownership] Eliminate -assume-parsing-unqualified-ownership-sil now that it is a no-op. #21439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat it is a no-op.
I am doing this separately from the actual change to eliminate the option to make it easier to review.
|
@swift-ci test |
|
NOTE: The parsing flag in SILBuilder is removed in this commit since it was only needed to handle cases where we did not know if we had ownership or not yet when creating a function. With the new design around [ossa] we always know if a function is in ownership form or not /before/ we insert instructions into it. |
atrick
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I split the test changes into a separate commit to ease review.