[CodeSynthesis] Make sure that LazyInitializerExpr has a type
#21441
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjmccall I've added a type to |
|
I'm a little uncomfortable with the fallback; it seems like something we should be asserting. |
|
@rjmccall sure, I can make this is a assert. It's just in general we create a type variable in place of missing type to attempt to infer it. |
xedin
force-pushed
the
fix-lazy-init-expr-csgen
branch
from
90331a0 to
d07e317
Compare
|
@rjmccall Alright, I've converted type variable to assert. |
|
@swift-ci please smoke test |
Currently when `LazyInitializerExpr` is added to the AST it's not given an explicit type. Because of that constraint solver silently fails in contraint generator without diagnostic. But since sub-expression associated with `LazyInitializerExpr` is already type-checked it makes sense to set its type explicitly.
xedin
force-pushed
the
fix-lazy-init-expr-csgen
branch
from
d07e317 to
20b7c2a
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
LazyInitializerExpris added to the AST it's notgiven an explicit type. Because of that constraint solver silently
fails in contraint generator without diagnostic. But since
sub-expression associated with
LazyInitializerExpris alreadytype-checked it makes sense to set its type explicitly.