Skip to content

[5.0][runtime] Add tests of pre-stable ABI objects with the stable ABI runtime #21479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

gparker42
Copy link
Contributor

Someday old Swift apps using the pre-stable ABI may pass their objects to OS code implemented using the stable Swift ABI and runtime. This test verifies that the new Swift runtime handles such objects correctly.

This test does nothing until we enable the intended is-Swift bit in the stable ABI. At that point this test will run by creating ObjC classes and objects with bits set to mimic the pre-stable ABI.

…time (swiftlang#21403)


* [test] Fix objc_old_swift when objc/objc-internal.h is not in the SDK.
@gparker42 gparker42 requested a review from a team as a code owner December 21, 2018 02:35
@gparker42
Copy link
Contributor Author

Cherry-picked from #21403.

@gparker42
Copy link
Contributor Author

@swift-ci please smoke test

@gparker42
Copy link
Contributor Author

@apple/swift5-branch-managers This is a test-only change for Swift stable ABI. It won't actually test anything until a later flag change so it is not high priority yet.

@AnnaZaks
Copy link
Contributor

@swift-ci please test

@bob-wilson bob-wilson merged commit 2322e5c into swiftlang:swift-5.0-branch Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants