[5.0] Fix SILCombine metatype cast optimization to avoid extending lifetimes. #21501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cannot be correctly done as a SILCombine because it must create new instructions at a previous location. Move the optimization into CastOptimizer. Insert the new metatype instructions in the correct spot. And manually do the replaceAllUsesWith and eraseInstruction steps. Fixes <rdar://problem/46746188> crash in swift_getObjCClassFromObject. (cherry picked from commit 65c95dd)
|
Reviewed by @eeckstein . |
|
@swift-ci test. |
eeckstein
approved these changes
Dec 21, 2018
|
Build failed |
|
@swift-ci test linux. |
eeckstein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cannot be correctly done as a SILCombine because it must create
new instructions at a previous location. Move the optimization into
CastOptimizer. Insert the new metatype instructions in the correct
spot. And manually do the replaceAllUsesWith and eraseInstruction
steps.
Fixes rdar://problem/46746188 crash in swift_getObjCClassFromObject.
(cherry picked from commit 65c95dd)