[Type checker] Basic ambiguity resolution + diagnostics for dynamic replacement #21502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eplacement. We weren't doing much validation when dynamically replacing storage declarations, and has an assert() that should be an error. Clean up this area a bit, dealing with simple ambiguities (i.e., there are two properties or subscripts with different type signatures; pick the matching one) and reporting an error when there is a true ambiguity. Fixes rdar://problem/46737657.
|
@swift-ci please smoke test and merge |
slavapestov
reviewed
Dec 21, 2018
| } | ||
|
|
||
| auto interfaceType = value->getInterfaceType(); | ||
| if (interfaceType->hasError()) |
There was a problem hiding this comment.
This should not be necessary -- we always build a function type with the correct 'shape' nowadays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't doing much validation when dynamically replacing storage
declarations, and has an assert() that should be an error. Clean up this
area a bit, dealing with simple ambiguities (i.e., there are two
properties or subscripts with different type signatures; pick the
matching one) and reporting an error when there is a true ambiguity.
Fixes rdar://problem/46737657.