Minor improvements to SIL verifier #21504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
commented
Dec 21, 2018
| @objc @inlinable deinit { | ||
| print("bye") | ||
| } | ||
| @objc deinit |
There was a problem hiding this comment.
@jrose-apple @objc is a no-op on a deinit isn't it? Should we warn and remove the attribute?
There was a problem hiding this comment.
This is how it gets printed right now, so we have to handle reading it back in.
There was a problem hiding this comment.
*shrug* A warning sounds fine. I'd also be happy if we (additionally) didn't print it here.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
jrose-apple
approved these changes
Dec 21, 2018
…thods in resilient classes
Just like a switch_enum, switch_enum_addr must have a default case if the enum is resilient from the current function.
slavapestov
force-pushed
the
sil-verifier-checks
branch
from
a6e3464 to
d8cf20e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
jrose-apple
approved these changes
Dec 21, 2018
|
Build failed |
|
Source compatibility “failures” are UPASS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some checks that we're not doing non-resilient things to resilient types inside inlinable functions, and fix two bugs caught by this.