Rework swift-stress-tester repo building #21523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes build-script-impl use a new, shared version of swift-stress-tester’s build-script-helper.py which also supports building swift-evolve. It also adds the necessary flags and variables to build swift-evolve from build-script.
This was referenced Dec 22, 2018
beccadax
added a commit
to beccadax/swift-stress-tester
that referenced
this pull request
Jan 2, 2019
These changes allow an invocation to specify whether it should build SourceKitStressTester or SwiftEvolve. In theory, it should behave virtually identically for SourceKitStressTester, but also work for SwiftEvolve. This commit also contains matching changes to SwiftEvolve’s package configuration. With those changes, it will build correctly *only* through build-script-helper. Finally, it includes changes to evolve-swiftCore.sh to build SwiftEvolve through the swift build-script command. This won’t actually work until swiftlang/swift#21523 lands with that support, so evolve-swiftCore.sh is temporarily broken.
|
Please test with following pull request: @swift-ci Please Build Toolchain macOS Platform |
|
(Using the toolchain build to test that swift-stress-tester will still build with these changes.) |
|
Please test with following pull request: @swift-ci Please Build Toolchain macOS Platform |
|
macOS Toolchain Install command |
|
@swift-ci please smoke test |
beccadax
changed the title
|
@swift-ci please build toolchain |
|
@brentdax This is a known issue, I will try to look into this issue. However, you should be able to download the toolchain. |
beccadax
deleted the
build-script-impl-evolved-into-longer-build-script-impl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes build-script-impl use a new, shared version of swift-stress-tester’s build-script-helper.py which also supports building swift-evolve. It also adds the necessary flags and variables to build swift-evolve from build-script.
This PR depends on swiftlang/swift-stress-tester#26, which moves the script to its new location and leaves a shim at the old name for compatibility. That PR has now landed, so this one can be merged when ready.
To do: