Skip to content

[SILGen] lower camel case on enum cases in a few tests #21525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2019

Conversation

nordicio
Copy link
Contributor

Tests were using an old Swift naming convention for enum cases, now there are some fewer.

@slavapestov

@CodaFi
Copy link
Contributor

CodaFi commented Dec 23, 2018

Thanks for the patch, but there's a few thousand enum cases sprinkled throughout the test suite that share this problem and it would be pretty noisy if we were to start migrating them. The test here is meant to exercise code paths in the compiler, so sticking to a style guide, while important, isn't a primary concern here.

@nordicio
Copy link
Contributor Author

I understand. :)

I had a brief discussion with @slavapestov about it here: https://twitter.com/slava_pestov/status/1075002706316705792

“Finally got it working - just to discover that it's being used everywhere. 😆 Is there any value in converting the tests to use the current convention?”

If there is value to it, it could be a way for me to learn more about the architecture while contributing something. But I understand if there isn’t.

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test and merge

@slavapestov slavapestov self-assigned this Jan 13, 2019
@swift-ci swift-ci merged commit ecebce8 into swiftlang:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants