Skip to content

Add Zip2Sequence.underestimatedCount #21530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dennisvennink
Copy link
Contributor

@dennisvennink dennisvennink commented Dec 23, 2018

Partly resolves SR-9570. I'll create a new PR for the other cases.

@CodaFi CodaFi requested a review from airspeedswift December 23, 2018 16:35
@dennisvennink dennisvennink force-pushed the zip2sequence-underestimatedcount branch 2 times, most recently from fc67e47 to 654026d Compare December 23, 2018 17:03
@stephentyrone
Copy link
Contributor

@swift-ci please test

@dennisvennink dennisvennink force-pushed the zip2sequence-underestimatedcount branch from 654026d to f6cd9c1 Compare December 24, 2018 13:45
@dennisvennink dennisvennink changed the title Add Zip2Sequence.underestimatedCount Add Missing Implementations of underestimatedCount Dec 24, 2018
@stephentyrone
Copy link
Contributor

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 654026df7cb784c6ec4bb72b53e114dd821b3845

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 654026df7cb784c6ec4bb72b53e114dd821b3845

@stephentyrone
Copy link
Contributor

@dennisvennink do you want to do further work on this branch for other missing cases, or should I merge it?

@dennisvennink dennisvennink changed the title Add Missing Implementations of underestimatedCount Add Zip2Sequence.underestimatedCount Jan 2, 2019
@dennisvennink
Copy link
Contributor Author

@dennisvennink do you want to do further work on this branch for other missing cases, or should I merge it?

Merging is fine, thank you. I'll create a new PR for the other cases.

@stephentyrone stephentyrone merged commit 45429ff into swiftlang:master Jan 2, 2019
@dennisvennink dennisvennink mentioned this pull request Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants