IRGen: COMDAT the force load thunks #21533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
force-pushed
the
excessive-force
branch
from
a99f3eb to
e277954
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Use `ApplyIRLinkage` to the force load thunks to permit multiple emissions to be COMDATed on Windows. The multi-module tests would emit the symbols multiply and would fail to link.
compnerd
force-pushed
the
excessive-force
branch
from
e277954 to
e6354fe
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
The only difference this causes is that we now go from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ApplyIRLinkageto the force load thunks to permit multipleemissions to be COMDATed on Windows. The multi-module tests would emit
the symbols multiply and would fail to link.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.