fix bug where AD is not always seeing custom [differentiable] attrs #21565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SILGen generates SIL for an expression like
3 * x
it creates aSILFunciton
forFloat.*
but does not populate thatSILFunction
with data like the list of[differentiable]
attrs. The AD pass does not load this data until after runninglookUpMinimalDifferentiationTask
, solookUpMinimalDifferentiationTask
does not find the custom adjoint. So AD differentiatesFloat.*
wrt the second parameter instead of using the custom adjoint.The
struct_extract
differentiation patch that I am working on exposes this, so I split this fix out into its own PR.