[SourceKit] Use diagnostics for arg parsing #21605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, you will no longer receive "error when parsing the compiler arguments". Instead, you will receive the underlying error, like "error: unable to load output file map 'output_file_map.json': No such file or directory"
DavidGoldman
changed the title
|
@swift-ci please smoke test |
|
Looks like this causes sourcekit to crash when diagnostics are emitted. I believe the DiagnosticConsumer needs to have the same lifetime as the DiagnosticsEngine, but your change moves the consumer into a different stack frame. |
|
Updated to remove the Consumer once it's no longer needed (after the Error string has been captured) |
benlangmuir
reviewed
Jan 8, 2019
|
@swift-ci please smoke test |
benlangmuir
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, you will no longer receive
error when parsing the compiler argumentswhen SourceKit fails to parse the invocation arguments.Instead, you will receive the underlying error, like
error: unable to load output file map 'output_file_map.json': No such file or directoryThis is helpful to figure out which arguments in the compiler invocation are considered invalid (as opposed to a generic error).