Skip to content

Correct OS suffix for Linux #21612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Conversation

johnno1962
Copy link
Contributor

Hi Apple,

Currently, the build-toolchain script produces an archive with a filename swift-LOCAL-2019-01-02-a-osx.tar.gz when building on Linux which can be confusing. This minor fix changes the suffix to swift-LOCAL-2019-01-02-a-linux.tar.gz.

Cheers.

@compnerd
Copy link
Member

compnerd commented Jan 3, 2019

CC: @gottesmm

@compnerd
Copy link
Member

compnerd commented Jan 3, 2019

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

swift-ci commented Jan 3, 2019

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 0a6de02

Install command
tar zxf swift-PR-21612-114-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

swift-ci commented Jan 3, 2019

macOS Toolchain
Download Toolchain
Git Sha - 0a6de02

Install command
tar -zxf swift-PR-21612-151-osx.tar.gz --directory ~/

@compnerd
Copy link
Member

compnerd commented Jan 3, 2019

@swift-ci please smoke test

Copy link
Contributor

@Rostepher Rostepher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@compnerd compnerd merged commit 550478a into swiftlang:master Jan 4, 2019
@johnno1962
Copy link
Contributor Author

Thanks @compnerd

@johnno1962 johnno1962 deleted the os-suffux branch January 4, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants