[SILGen] Make sure profile increments gets assigned the correct scope.

[dcci]

rdar://problem/46686369

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

[dcci]

@swift-ci please test

[dcci]

Turns out that order matters (TM), so I need to think about something else.

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - a6db5e9

[vedantk]

Yes, I think the increment must occur before the statement body is emitted, otherwise control flow changes within the body might result in missed increments.

Would applying a line 0 location to the profile counter increment address the verifier failure?

[dcci]

@vedantk @adrian-prantl
while I agree that applying line zero to the increment a good thing to do, I don't think it's going to fix the verifier failure. Is there an equivalent of line 0 for scopes? I'm not aware of it.

Aside, maybe the verifier should skip instructions with a compiler generated line?

[adrian-prantl]

@vedantk @adrian-prantl
while I agree that applying line zero to the increment a good thing to do, I don't think it's going to fix the verifier failure. Is there an equivalent of line 0 for scopes? I'm not aware of it.

The "equivalent" is using SILBuildWithScope<>(insertionpoint) which inherits the scope from the insertion point.

Aside, maybe the verifier should skip instructions with a compiler generated line?

Probably not, they will still bloat .debug_info needlessly.

[dcci]

Superseded by #21777