ApplyIRLinkage cleanups #21639
Merged
ApplyIRLinkage cleanups #21639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `IRLInkage::InternalLinkOnceODR` linkage rather than computing that in a couple of sites. This gives us semantic meaning to the linkage being applied. NFC.
Create a new named IRLinkage type: `InternalWeakODR`. This just gives the IRLinkage a semantic name rather than the computed value. NFC.
Sinking this logic into the IRLinkage application means that we can clean up the various sites that are handling the IRLinkage and/or DLLStorage to apply IRLinkage semantically, making the code easier to understand as well as avoiding the proliferation of the `useDLLStorage` checks.
Now that DLLStorage is only applied when needed, always pass the correct DLLStorage. The IRLinkage applicator will determine if the DLLStorage should be applied or not.
Create two new semantic names: `ExternalImport` and `ExternalExport`. These are for symbols which are either imported from an external module or exported for consumption by external modules.
Use `ApplyIRLinkage` rather than manually applying the DLLStorage. This makes it much more apparent as to the desired semantic linkage desired.
|
@swift-ci please test |
|
@rjmccall - I believe that this was the type of cleanup that you were alluding to. I finally got around to actually doing some amount of it |
rjmccall
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.