[runtime] Fortify the swift_demangle API. #2169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
| flags: 0) | ||
|
|
||
| if (demangledNamePtr == nil) { | ||
| return mangledName; |
AnnaZaks
force-pushed
the
demangle
branch
2 times, most recently
from
a969035 to
f988707
Compare
|
@swift-ci Please test |
|
@swift-ci Please smoke test Linux platform |
| #define SWIFT_RUNTIME_PORTABILITY_H | ||
| #include <stddef.h> | ||
|
|
||
| size_t _swift_strlcpy(char *dst, const char *src, size_t maxlen); |
There was a problem hiding this comment.
Please wrap in extern "C".
There was a problem hiding this comment.
Agreed not to wrap in extern "C" because this is not a publicly exposed API.
Remove the reference to String, which leaks internal implementation details, check for invalid inputs, and make the API more flexible. Remove the similar Swift API, since it provides no additional value.
This safer function is missing on Linux.
|
@swift-ci Please smoke test Linux platform |
| // Indicate a failure if the result does not fit and will be truncated | ||
| // and set the required outputBufferSize. | ||
| if (*outputBufferSize < result.length() + 1) { | ||
| *outputBufferSize = result.length() + 1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the reference to String, which leaks internal implementation details,
check for invalid inputs, and make the API more flexible. Remove the similar
Swift API, since it provides no additional value.