[5.0 12-12-2018] [IRGen/Runtime] Anonymous context descriptors can (should be) generic. #21692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anonymous context descriptors were being treated as non-generic by IRGen, which lead to problems for (file)private types within generic types. Emit generic parameters and requirements for anonymous contexts as well. The runtime was mostly prepared for this, and the ABI already accounted for it, so the runtime change is minor---it only affected building a demangle tree from metadata. Fixes rdar://problem/46853806. (cherry picked from commit 4cdb26d)
AnnaZaks
approved these changes
Jan 8, 2019
DougGregor
deleted the
generic-anonymous-context-descriptors-5.0-12-12-2018
branch
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Anonymous context descriptors were being treated as non-generic by
IRGen, which lead to problems for (file)private types within generic
types. Emit generic parameters and requirements for anonymous contexts
as well, and deal with this in the runtime.
Scope: Regression from 4.2. Affects private generic types within private generic types.
Issue: rdar://problem/46853806
Risk: Low; small change to type metadata emission
Testing: Swift CI, two projects that triggered this particular bug
Reviewed by: @jckarter