-
Notifications
You must be signed in to change notification settings - Fork 10.5k
const evaluator: string values and init operations #21711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
return None; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcrasi I wonder if it would be better to make a separate function for lines 560 to 591 that handles well-known functions. As we plan to add more well-known functions, it would make this more modular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@marcrasi LGTM otherwise. |
@jckarter Related to your suggestion on handling collection types symbolically, I just wanted to give heads up that this PR adds basic support for symbolically representing strings and interpreting their initializers. Representation for arrays and array initialization is added by this PR #21703 |
@swift-ci Please smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@swift-ci Please test and merge |
1 similar comment
@swift-ci Please test and merge |
@marcrasi Once this is merged, can we upstream enums before merging arrays? |
Adds string values, string initialization operations (using a "WellKnownFunction" mechanism), and some tests that invoke string initialization but do not check the contents of the strings.
This very basic string handling is all that we have in the tensorflow branch const evaluator right now.