[sil] Add a run of ome into the lowering pass pipeline. #21716
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason why I am doing this is I am in the process of trying to have the entire -Onone pipeline run with ownership. As part of this the question comes up: when do we strip out ownership if at all? IRGen really doesn't have any need to know about ossa, so it makes sense to strip it always at this point. This conveniently also ensures that the SILModule before IRGen time (i.e. when we serialize at -Onone) is always in ownership.
|
@swift-ci smoke test |
|
This wont land before: #21713 |
|
This is no longer needed. I am doing this in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why I am doing this is I am in the process of trying to have the
entire -Onone pipeline run with ownership. As part of this the question comes
up: when do we strip out ownership if at all? IRGen really doesn't have any need
to know about ossa, so it makes sense to strip it always at this point. This
conveniently also ensures that the SILModule before IRGen time (i.e. when we
serialize at -Onone) is always in ownership.