IRGen: apply IR linkage to trivial property descriptors #21720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @jckarter |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
This needs a testcase |
|
@slavapestov hmm, I can add a separate test case for this, but the existing test cases cover this. |
This ensures that the trivial property descriptors is externally accessible on targets like Windows which does not export symbols by default. Thanks to Joe Groff for the pointer about the global aliases for trivial property descriptors!
compnerd
force-pushed
the
trivial-property-descriptors
branch
from
800bec5 to
fc86d09
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the trivial property descriptors is externally
accessible on targets like Windows which does not export symbols by
default. Thanks to Joe Groff for the pointer about the global aliases
for trivial property descriptors!
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.