ClangImporter: setup macros for WinSDK import #21735
Conversation
|
@swift-ci please test |
|
CC: @jrose-apple |
|
Build failed |
|
Build failed |
| @@ -541,6 +541,23 @@ getNormalInvocationArguments(std::vector<std::string> &invocationArgStrs, | |||
| }); | |||
| } | |||
|
|
|||
| if (triple.isOSWindows()) { | |||
There was a problem hiding this comment.
This will also kick in for Cygwin. Is that desired?
|
Also, worth writing a test for with a manual target triple! |
|
@jrose-apple - yeah, this definitely needs a test. I think that Cygwin also needs these macros defined. IIRC, @tinysun212 had done the cygwin port in the 3.0 timeframe? |
compnerd
force-pushed
the
windows-target-macros
branch
from
f94d07b to
9e52cef
Compare
|
@swift-ci please test and merge |
|
You might also consider defining |
|
@slavapestov I don't think that defining |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
compnerd
force-pushed
the
windows-target-macros
branch
from
9e52cef to
a969f6a
Compare
|
@swift-ci please test and merge |
Windows SDK requires that the platform target is identified. Unfortunately, `cl` does not specify the value, so we cannot actually specify the value in the clang frontend. Specify this in the swift frontend as this obscures the clang invocation.
compnerd
force-pushed
the
windows-target-macros
branch
from
a969f6a to
e012dc7
Compare
|
@swift-ci please test and merge |
Windows SDK requires that the platform target is identified.
Unfortunately,
cldoes not specify the value, so we cannot actuallyspecify the value in the clang frontend. Specify this in the swift
frontend as this obscures the clang invocation.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.