Skip to content

Add a regression test for SR-9624 #21741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Conversation

jrose-apple
Copy link
Contributor

It got fixed somewhere along the way in Swift 5.

https://bugs.swift.org/browse/SR-9624

It got fixed somewhere along the way in Swift 5.
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@jrose-apple jrose-apple merged commit 62c4036 into swiftlang:master Jan 9, 2019
@jrose-apple jrose-apple deleted the sr9624 branch January 9, 2019 19:06
@slavapestov
Copy link
Contributor

To give credit where credit is due this was fixed by @rjmccall as part of coroutines:

commit c491f1b72152f48390d560f99b6aa0ea243fe19e
Author: John McCall <[email protected]>
Date:   Wed Aug 22 01:46:55 2018 -0400

    Implement reabstraction of inouts in witness and reabstraction thunks.
    
    This is a longstanding gap in the implementation that quite possibly
    never bit anyone in the wild.  I've only gotten around to implementing
    it now because this same code path will be used to reabstract inout
    yields.  That means that, rather than only affecting functions with
    an abstraction difference in an inout parameter type, this can affect
    all storage with any abstraction difference in the stored value type.
    So it's time to fill in this gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants