Skip to content

[Parser] Expose a flag to allow users explicitly disable delayed parsing. NFC #21750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Jan 9, 2019

Discussed with @dcci, this patch is necessary to fix an lldb test failure. rdar://38396444

…ing. NFC

Discussed with @dcci, this patch is necessary to fix an lldb test failure. rdar://38396444
@nkcsgexi nkcsgexi requested a review from dcci January 9, 2019 22:35
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 9, 2019

@swift-ci please test

Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the parser enough to approve, but I can tell this is good enough for my purposes.

@nkcsgexi nkcsgexi merged commit cf3e40f into swiftlang:master Jan 10, 2019
@nkcsgexi nkcsgexi deleted the parser-delayed-control branch January 10, 2019 01:05
@dcci
Copy link
Member

dcci commented Jan 10, 2019

I'll write the lldb patch now.
We really want this to be on 5.0 as well ,FYI.

@nkcsgexi
Copy link
Contributor Author

i'll cherry-pick there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants