-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[test] Run all the benchmarks once as a validation test #21751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Run all the benchmarks once as a validation test #21751
Conversation
This is most useful in +Asserts builds of the stdlib, which isn't a useful configuration for actual benchmarking, but could still uncover issues in the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes perfect sense.
BTW, we have been discussing with @eeckstein and @shahmishal building the benchmarks as part of smoke test in #21477 (comment).
Running with the parameters you have here currently takes 7 seconds on my 2008 MBP and when I'm done with all the Janitor Duty: Legacy Factor cleanup, this should be sub-second... so then we should probably move this to test
, instead of validation-test
.
@swift-ci please test |
Build failed |
An this is why needed this yesterday ;-) Crash Details:
Edit: Oh… but that is the |
@swift-ci please test |
I put it in validation-test for two reasons:
So, yeah, maybe it does make sense to move it to test/. I'll merge it as is for now, though, so we can get the coverage immediately. |
This is most useful in +Asserts builds of the stdlib, which isn't a useful configuration for actual benchmarking, but could still uncover issues in the implementation. (There actually is one right now found by SuperChars, SR-9203, so I can't land this yet.)