Clean up matchTypes() and related code a little #21763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@xedin This is the first step in a larger cleanup of some code around InOutType and the weird LValueType/InOutType conversions. Just wanted to post this part for review since I know you're hacking here too as part of the diagnostics work. If you want I can hold off merging until your changes go in, I don't mind rebasing. |
xedin
approved these changes
Jan 10, 2019
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
Hmm... |
|
Unsubscribe
…On Thu, Jan 10, 2019, 7:41 AM Slava Pestov ***@***.*** wrote:
/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift-corelibs-foundation/TestFoundation/TestNSString.swift:393: error: TestNSString.test_FromContentsOfURL : XCTAssertEqual failed: ("Pf
07:34:08 <o�
07:34:08
07:34:08 e is encoded as ISO-8859-1
07:34:08 ÀÁÂÃÄÅÿ
07:34:08 ±
07:34:08 ") is not equal to ("This file is encoded as ISO-8859-1
07:34:08 ÀÁÂÃÄÅÿ
07:34:08 ±
07:34:08 ") -
Hmm...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#21763 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AaqVIHNBeRVKbQ9hSc65Ow06mm7rJFwIks5vB0MWgaJpZM4Z4v6Z>
.
|
slavapestov
force-pushed
the
match-types-cleanup
branch
2 times, most recently
from
134fed6 to
4dfbd8f
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.