Reduce compile time for large strongly connected call graphs. #21779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves SwiftSyntax release build speed by 4x. Limit the size of the sets tracked by inter procedural AccessedStorageAnalysis. There is a lot of leeway in this limit since "normal" code doesn't come close to hitting it and SwiftSyntax compile time isn't noticeably affected until 10x this limit. This change also avoids reanalyzing function bodies once results have bottomed out and avoids copying sets in the common case. Fixes <rdar://problem/46905624> Release build time regression, a lot of time spent on AccessEnforcementOpts::run(). This is just a band aid. The fundamental problem is really: <rdar://problem/47195282> Recomputing BottomUpIPAnalysis takes most of the SwiftSyntax compile time. SwiftSyntax compile time is still at least an order of magnitude longer than it should be.
|
@swift-ci test. |
|
@swift-ci benchmark. |
|
@swift-ci test source compatibility. |
Build comment file:Performance: -Onone
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview |
|
Build failed |
shajrawi
approved these changes
Jan 11, 2019
|
@swift-ci test linux platform. |
eeckstein
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves SwiftSyntax release build speed by 4x.
Limit the size of the sets tracked by inter procedural
AccessedStorageAnalysis. There is a lot of leeway in this limit since
"normal" code doesn't come close to hitting it and SwiftSyntax compile
time isn't noticeably affected until 10x this limit.
This change also avoids reanalyzing function bodies once results have
bottomed out and avoids copying sets in the common case.
Fixes rdar://problem/46905624 Release build time regression, a lot of time spent on AccessEnforcementOpts::run().
This is just a band aid. The fundamental problem is really:
rdar://problem/47195282 Recomputing BottomUpIPAnalysis takes most of
the SwiftSyntax compile time.
SwiftSyntax compile time is still at least an order of magnitude
longer than it should be.