[AutoDiff] Fix AD diagnostics tracking. #21788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Jan 11, 2019
| @@ -3439,7 +3464,7 @@ class AdjointEmitter final : public SILInstructionVisitor<AdjointEmitter> { | |||
| // TODO: Change this to a note when we emit an error at the @autodiff | |||
There was a problem hiding this comment.
Can this TODO note be removed?
There was a problem hiding this comment.
Good catch! I think I’ll get rid of em in my next PR since CI has passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DifferentiationInvoker so that errors are guaranteed to be reported in the differentiation pass.