Skip to content

[AutoDiff] Add adjoints for sum and mean. #21790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2019

Conversation

dan-zheng
Copy link
Contributor

@dan-zheng dan-zheng commented Jan 11, 2019

Add adjoints for sum and mean, which are commonly used reduction operations.
Overload variadic Tensor ops with array argument versions. Array argument versions
are more general than variadic versions.
Remove redundant conformances from Tensor gradient operators.

Add adjoints for sum and mean, which are commonly used reduction operations.
Remove redundant conformances from `Tensor` gradient operators.
@dan-zheng dan-zheng added the tensorflow This is for "tensorflow" branch PRs. label Jan 11, 2019
@dan-zheng dan-zheng requested a review from rxwei January 11, 2019 06:23
@dan-zheng
Copy link
Contributor Author

I believe there's a @autodiff function release related error. Triggering tests to find out.
@swift-ci Please test tensorflow

….swift`.

GPE does not interact well with VJPs and crashes.
Filed SR-9638.
@dan-zheng dan-zheng force-pushed the reduction-op-adjoints branch from ce4d744 to 9f280b3 Compare January 11, 2019 07:34
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

1 similar comment
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

`Tensor` ops that take array arguments are useful and more general than
variadic versions.

Declare `@differentiable` on new array argument ops.
@dan-zheng dan-zheng force-pushed the reduction-op-adjoints branch from d569d08 to 9a4b452 Compare January 11, 2019 08:21
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

1 similar comment
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@rxwei
Copy link
Contributor

rxwei commented Jan 11, 2019

@swift-ci please test tensorflow

@dan-zheng
Copy link
Contributor Author

@swift-ci Please clean test tensorflow

@rxwei rxwei merged commit 66437a8 into swiftlang:tensorflow Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants