[silcombine] (store (struct_gep addr) value) -> (store addr (struct v… #21791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
gottesmm
force-pushed
the
pr-5a4e17411328a11ec4d37cc30ead812b7087badf
branch
from
98f033a to
632ddd5
Compare
|
As an observer, can I ask why the new pattern is better than the old one? |
|
@jrose-apple Semantically the two are equivalent. The difference is that at an optimizer level it is easier to promote from further up the type tree to a lower level of the type tree vs promoting from a lower level of the type tree to an upper level of the type tree. Generally the former is possible and the other is not. This PR changes the only case where it is possible to promote an available value of field in a type tree to an available value of the parent type (namely where one where all of the struct fields are single element) to one that most passes handle, the other. |
shajrawi
approved these changes
Jan 11, 2019
|
Thanks for the explanation! |
gottesmm
force-pushed
the
pr-5a4e17411328a11ec4d37cc30ead812b7087badf
branch
from
632ddd5 to
556001a
Compare
slavapestov
approved these changes
Jan 11, 2019
…alue)) for single field structs.
gottesmm
force-pushed
the
pr-5a4e17411328a11ec4d37cc30ead812b7087badf
branch
from
556001a to
cf43a93
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alue)) for single field structs.