ParseSIL: prevent _weakLinked on COFF targets
#21798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jckarter @jrose-apple ... in case you guys care. But, seems pretty easy to diagnose this early enough thanks to @jckarter's very helpful tip about |
|
@swift-ci please test |
|
Works for me. |
|
LGTM too. |
|
Build failed |
PE/COFF does not provide weak linking semantics. Ensure that we diagnose use of `_weakLinked` on those targets rather than consuming it and attempting to generate IR for that.
compnerd
force-pushed
the
no-weakness-here
branch
from
a75af81 to
03af946
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PE/COFF does not provide weak linking semantics. Ensure that we
diagnose use of
_weakLinkedon those targets rather than consuming itand attempting to generate IR for that.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.