Pseudo-cherry-pick https://github.com/apple/swift/commit/96691208e9b8… #21807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
milseman
approved these changes
Jan 11, 2019
|
Build failed |
|
Yup, that's all! |
|
@swift-ci please test |
airspeedswift
approved these changes
Jan 14, 2019
| @usableFromInline // FIXME(sil-serialize-all) | ||
| @objc | ||
| internal init() {} | ||
| class __SwiftNativeNSString { |
There was a problem hiding this comment.
We should try and keep all access explicit, so this should have an internal (doesn't need to happen in this PR tho)
|
Build failed |
…ce it no longer merges cleanly over
Catfish-Man
force-pushed
the
swift-5.0-branch
branch
from
2c5f833 to
97648b1
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtually all of the substantive changes made it over already, but a few were missed. This is ABI impacting, so we should take it for 5.0.
cc @airspeedswift