Skip to content

enum SourceKitdError case to lower camel case #21821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2019
Merged

enum SourceKitdError case to lower camel case #21821

merged 1 commit into from
Jan 15, 2019

Conversation

kichiemon
Copy link
Contributor

@kichiemon kichiemon commented Jan 12, 2019 •
edited
Loading

I changed two case naming of enum EditorOpenError.

Because enum case should be named by lower camel case.

Follow case conventions. Names of types and protocols are UpperCamelCase. Everything else is lowerCamelCase.
https://swift.org/documentation/api-design-guidelines/

  • EditorOpenError to editorOpenError
  • EditorCloseError to editorCloseError

@kichiemon
change enum SourceKitdError's case to lower camel case
15f9ddc 
- EditorOpenError to editorOpenError
- EditorCloseError to editorCloseError
@jrose-apple jrose-apple requested a review from nkcsgexi January 14, 2019 18:12
@nkcsgexi
Copy link
Contributor

@swift-ci please smoke test

@nkcsgexi nkcsgexi merged commit 74dd07f into swiftlang:master Jan 15, 2019
@kichiemon kichiemon deleted the enum-case-to-lowercamelcase branch January 15, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kichiemon @nkcsgexi