[Sema] [AutoDiff] Modify/fix Differentiable derived conformances.
#21871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix crasher regarding bad interaction between AdditiveArithmetic and
Differentiable derived conformances, where both code paths attempt to
synthesize memberwise initializers.
- Conform synthesized `AllDifferentiableVariables` struct to `KeyPathIterable`
if parent conforms to `KeyPathIterable`.
- This is important for key-path based optimizer definitions.
- Modify associated struct synthesis to check whether any `@noDerivative`
stored properties exist.
- If any `@noDerivative` stored properties exist, `AllDifferentiableVariables`
struct must be synthesized.
- Refactor derived conformances code, add tests.
rxwei
approved these changes
Jan 15, 2019
|
@swift-ci please test tensorflow |
|
@swift-ci Please test tensorflow macOS |
|
@swift-ci Please clean test tensorflow macOS |
1 similar comment
|
@swift-ci Please clean test tensorflow macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crasher regarding bad interaction between AdditiveArithmetic and
Differentiable derived conformances, where both code paths attempt to
synthesize memberwise initializers.
Conform synthesized
AllDifferentiableVariablesstruct toKeyPathIterableif parent conforms to
KeyPathIterable.Modify associated struct synthesis to check whether any
@noDerivativestored properties exist.
@noDerivativestored properties exist,AllDifferentiableVariablesstruct must be synthesized.
Refactor derived conformances code, add tests.