Refactor delayed member parsing and fix a bug #21879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkcsgexi There's still a bug I need to fix here and the 'test' patch will be squashed with the right commit. Other than that if you want to take a look please go ahead. |
slavapestov
force-pushed
the
fix-delayed-member-parsing
branch
from
446f5ad to
1c30353
Compare
…d of a callback function
Fixes <rdar://problem/47305142>.
…d non-primary files
slavapestov
force-pushed
the
fix-delayed-member-parsing
branch
from
e4dc9c0 to
482f73c
Compare
|
@swift-ci Please test source compatibility |
|
apple/swift-lldb#1230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bad interaction between the old delayed function body parsing, and the new delayed member parsing that was added post-4.2.
When delayed member parsing parses a nominal type or extension body, it would create a new parser instance without delayed parsing callbacks. Since right now, nominal type bodies are parsed a lot more often than needed due to global operator lookup, this actually manifested as a regression because we were once again parsing function bodies in non-primary files.
Clean this up so that the delayed parsing callbacks are only used for code completion, with a new flag controlling skipping of function bodies, which is what we want in non-code completion, non-primary file frontend jobs.
Add a
scale_testto ensure that delayed function body parsing is kicking in for methods defined inside types, not just top-level functions like the old test was testing.