utils: port round-trip-syntax-test to windows #21884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
force-pushed
the
round-trip-flight
branch
from
5ce45df to
2ad01f6
Compare
|
@swift-ci please test |
|
CC: @bitjammer |
|
Build failed |
|
Build failed |
Use python's builtin diff rather than invoking `/usr/bin/diff` which does not exist on Windows. Decode the content into UTF-8 before processing it for the diff as the file reading will give us UTF-16 content on Windows.
compnerd
force-pushed
the
round-trip-flight
branch
from
2ad01f6 to
7d07ae4
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use python's builtin diff rather than invoking
/usr/bin/diffwhichdoes not exist on Windows. Decode the content into UTF-8 before
processing it for the diff as the file reading will give us UTF-16
content on Windows.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.