[stdlib][SR-2239][5.0] Implement AAPCS64 variable argument list support. #21885
+104
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the already existing support for x86_64 and s390 to implement AAPCS64 __VaListBuilder. The parts where each implementation differ are the x86_64 header, and the order of the general and vector registers. This change brings in one commit the changes introduced in swiftlang#20862 and in swiftlang#21237.
|
Sorry to bother again. I saw the first beta being released today, and I was wondering if this was left aside for a reason, or it is still intended to be merged in 5.0. BTW: I cannot start the tests myself. |
|
I'm planning to merge this next week -- holding off for a few days to avoid any extra risk as we're wrapping up the ABI changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the already existing support for x86_64 and s390 to implement AAPCS64 __VaListBuilder. The parts where each implementation differ are the x86_64 header, and the order of the general and vector registers.
This change brings in one commit the changes introduced in #20862 and in #21237.
Resolves SR-2239.
/cc @bob-wilson