WIP: build-script: add a flag to build libSwiftSyntaxParser only. #21901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
libparser-build
branch
from
3618fb0 to
6792481
Compare
|
@swift-ci please smoke test |
akyrtzi
reviewed
Jan 17, 2019
akyrtzi
reviewed
Jan 17, 2019
nkcsgexi
force-pushed
the
libparser-build
branch
from
6792481 to
c3f3286
Compare
akyrtzi
reviewed
Jan 17, 2019
utils/build-script-impl
Outdated
| @@ -1824,6 +1824,16 @@ function set_swiftsyntax_build_command() { | |||
| SWIFT_TEST="$(build_directory_bin ${LOCAL_HOST} swiftpm)/swift-test" | |||
| fi | |||
|
|
|||
| if [ "${BUILD_LIBPARSER_ONLY}" ]; then | |||
| # we don't have a compiler built so we have to use the one in the environment. | |||
| SWIFTC_USE="$(xcrun_find_tool swiftc)" | |||
There was a problem hiding this comment.
Nitpick but SWIFTC_BIN is better name here, it's used in other places in this script representing the same thing as here.
nkcsgexi
force-pushed
the
libparser-build
branch
from
c3f3286 to
6b34648
Compare
|
@swift-ci please smoke test |
akyrtzi
approved these changes
Jan 17, 2019
nkcsgexi
force-pushed
the
libparser-build
branch
from
6b34648 to
eefa0b1
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.