Skip to content

Remove all references to unused LitRe tool #21910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Remove all references to unused LitRe tool #21910

merged 2 commits into from
Jan 17, 2019

Conversation

gwynne
Copy link
Contributor

@gwynne gwynne commented Jan 16, 2019

CMakeLists.txt and a few other things still refer to LitRe, a tool once used for validating examples in .rst-format documentation. No distribution of this tool still exists and nothing in Swift still depends on it or would be validated by its use, so remove all remaining references. As a bonus, in the process a duplicate redundant invocation of find_program() for sphinx-build is also removed.

…lly removes redundant/duplicate check for sphinx-build binary.
@gwynne gwynne requested a review from gottesmm January 16, 2019 10:18
@gottesmm
Copy link
Contributor

Looks reasonable to me. @dabrahams I think is the one who committed this. Any objections DaveA?

@gottesmm
Copy link
Contributor

@swift-ci smoke test

@dabrahams
Copy link
Contributor

I'm a wholehearted endorser of this change.

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this!

@gwynne gwynne merged commit 664e565 into swiftlang:master Jan 17, 2019
@gwynne gwynne deleted the gwynne/drop-litre-references branch January 17, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants