Fix enum element constructor call with trailing closure [5.0] #21927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
…h can't have scalar-to-tuple or tuple-to-scalar" We use TupleShuffleExpr in RValue position for enum element payloads, and it can happen that the source is a scalar if you're calling the enum element constructor with a trailing closure. This reverts commit 7960660. Fixes <https://bugs.swift.org/browse/SR-9675>.
slavapestov
force-pushed
the
enum-element-trailing-closure-5.0
branch
from
d1455b2 to
1e8a0ba
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
AnnaZaks
approved these changes
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use TupleShuffleExpr in RValue position for enum element payloads, and
it can happen that the source is a scalar if you're calling the enum element
constructor with a trailing closure.
This reverts commit 7960660.
Fixes https://bugs.swift.org/browse/SR-9675.